chore: start testing both lowest-direct and highest package resolution strategy #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 735 defines dependency groups which is a bit different from optional dependencies -- notablely this dependency information is not exported as part of the package metadata. For dependencies needed for testing purposes, we can use dependency groups and having optional dependencies to focus on providing customizations for the users.
fanzeyi
force-pushed
the
push-rorwpxntzsnw
branch
14 times, most recently
from
f7a8152 to
d41665b
Compare
fanzeyi
changed the title
fanzeyi
force-pushed
the
push-rorwpxntzsnw
branch
from
d41665b to
2c5b53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #222 demonstrated, it is possible for us to introduce dependency to a newer version of a dependency package without breaking our CI.
This PR makes our GitHub Action to test for both
lowest-directandhighestpackage resolution strategy so we can make sure the lower bounds we write in our package dependency still work.Test Plan
GitHub Action on this PR still passes.